-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Private Service doesn't need a cluster IP #15392
base: main
Are you sure you want to change the base?
[wip] Private Service doesn't need a cluster IP #15392
Conversation
* change private K8s service to be a headless service * use clusteripnone constant
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test istio-latest-mesh |
782b772
to
91f2f8d
Compare
When we set 'ClusterIP: None' on the private service the activator can't perform the fallback service probing. This is needed while in mesh mode. This change tweaks the fallback probing to use the hostname of the private service instead of using a cluster IP. On caveat is that when using a headless service Istio/K8s doesn't perform any port translation 80 (http)->8012 (queue-proxy http). Thus we perform this lookup ourselves.
91f2f8d
to
a76d104
Compare
/test istio-latest-mesh |
@dprotaso: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This Pull Request is stale because it has been open for 90 days with |
@dprotaso what is the status of the PR, is this something you still want to pursue? |
This brings back "change private K8s service to be a headless service (#15170)" with some additional changes.
When we set 'ClusterIP: None' on the private service the activator
can't perform the fallback service probing. This is needed
while in mesh mode.
This change tweaks the fallback probing to use the hostname
of the private service instead of using a cluster IP.
On caveat is that when using a headless service Istio/K8s doesn't
perform any port translation 80 (http)->8012 (queue-proxy http).
Thus we perform this lookup ourselves.