Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Private Service doesn't need a cluster IP #15392

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dprotaso
Copy link
Member

This brings back "change private K8s service to be a headless service (#15170)" with some additional changes.

When we set 'ClusterIP: None' on the private service the activator
can't perform the fallback service probing. This is needed
while in mesh mode.

This change tweaks the fallback probing to use the hostname
of the private service instead of using a cluster IP.

On caveat is that when using a headless service Istio/K8s doesn't
perform any port translation 80 (http)->8012 (queue-proxy http).

Thus we perform this lookup ourselves.

* change private K8s service to be a headless service

* use clusteripnone constant
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2024
Copy link

knative-prow bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@dprotaso
Copy link
Member Author

/test istio-latest-mesh
/test istio-latest-mesh-short
/test istio-latest-mesh-tls

@dprotaso dprotaso force-pushed the drop-cluster-ip-use-service-hostname branch from 782b772 to 91f2f8d Compare July 11, 2024 21:19
When we set 'ClusterIP: None' on the private service the activator
can't perform the fallback service probing. This is needed
while in mesh mode.

This change tweaks the fallback probing to use the hostname
of the private service instead of using a cluster IP.

On caveat is that when using a headless service Istio/K8s doesn't
perform any port translation 80 (http)->8012 (queue-proxy http).

Thus we perform this lookup ourselves.
@dprotaso dprotaso force-pushed the drop-cluster-ip-use-service-hostname branch from 91f2f8d to a76d104 Compare July 11, 2024 21:27
@dprotaso
Copy link
Member Author

/test istio-latest-mesh
/test istio-latest-mesh-short
/test istio-latest-mesh-tls

Copy link

knative-prow bot commented Jul 12, 2024

@dprotaso: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_serving_main a76d104 link true /test unit-tests
istio-latest-mesh_serving_main a76d104 link false /test istio-latest-mesh
istio-latest-mesh-short_serving_main a76d104 link false /test istio-latest-mesh-short

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2024
@skonto
Copy link
Contributor

skonto commented Oct 24, 2024

@dprotaso what is the status of the PR, is this something you still want to pursue?

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants