Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update actions #2417

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/serving-writers knative/eventing-writers
/assign knative/serving-writers knative/eventing-writers

Produced by: knative-sandbox/knobots/actions/update-actions

Details:


Signed-off-by: Knative Automation <[email protected]>
@knative-prow-robot knative-prow-robot requested review from a team February 2, 2022 01:29
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 2, 2022
@pierDipi
Copy link
Member

pierDipi commented Feb 2, 2022

#1672

=== RUN   TestMetricsExport/OpenCensus
    e2e_test.go:194: Created exporter at localhost:12345
{"level":"info","ts":1643765719.1213918,"logger":"fallback","caller":"metrics/metrics_worker.go:76","msg":"Flushing the existing exporter before setting up the new exporter."}
{"level":"info","ts":1643765719.1526945,"logger":"fallback","caller":"metrics/opencensus_exporter.go:56","msg":"Created OpenCensus exporter with config:","config":{}}
{"level":"info","ts":1643765719.1530135,"logger":"fallback","caller":"metrics/metrics_worker.go:91","msg":"Successfully updated the metrics exporter; old config: &{knative.dev/project testComponent prometheus 1000000000 <nil>  false 19090 0.0.0.0}; new config &{knative.dev/project testComponent opencensus 1000000000 <nil> localhost:12345 false 0 }"}
    e2e_test.go:232: Timeout reading input
    e2e_test.go:238: Unexpected OpenCensus exports (-want +got):
          []metrics.metricExtract(Inverse(Sort, []string{
          	"knative.dev/project/testComponent/global_export_counts<>:2",
          	"knative.dev/project/testComponent/resource_global_export_count<>:2",
        - 	`knative.dev/project/testComponent/testing/value<project="p1",revision="r1">:0`,
          	`knative.dev/project/testComponent/testing/value<project="p1",rev`...,
          }))
    --- FAIL: TestMetricsExport/OpenCensus (5.11s)

/retest

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #2417 (1186aa3) into main (bab3d0d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2417      +/-   ##
==========================================
- Coverage   63.51%   63.50%   -0.02%     
==========================================
  Files         228      228              
  Lines        9990     9990              
==========================================
- Hits         6345     6344       -1     
- Misses       3344     3345       +1     
  Partials      301      301              
Impacted Files Coverage Δ
controller/controller.go 86.13% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab3d0d...1186aa3. Read the comment docs.

@dprotaso
Copy link
Member

dprotaso commented Feb 2, 2022

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@knative-prow-robot knative-prow-robot merged commit b619c92 into knative:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants