Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override QPS and Burst via flag #1778

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 6, 2020

Fixes #1700

Add --kube-api-qps and --kube-api-burst command-line flags
to control client QPS and Burst respectively.

The default value is set to 0 to keep backward compatibility.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 6, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 6, 2020
@pierDipi
Copy link
Member Author

pierDipi commented Oct 6, 2020

/cc dprotaso mattmoor

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #1778 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
- Coverage   68.25%   68.13%   -0.12%     
==========================================
  Files         218      218              
  Lines        9295     9305      +10     
==========================================
- Hits         6344     6340       -4     
- Misses       2636     2648      +12     
- Partials      315      317       +2     
Impacted Files Coverage Δ
injection/config.go 0.00% <0.00%> (ø)
test/gcs/mock/mock.go 90.32% <0.00%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46761ba...8c36cb8. Read the comment docs.

@pierDipi
Copy link
Member Author

pierDipi commented Oct 6, 2020

Ref: #1672

resource_view_test.go:371: failed to fetch prometheus metrics: Get "http://localhost:19090/metrics": dial tcp 127.0.0.1:19090: connect: connection refused
    --- FAIL: TestMetricsExport/Prometheus (0.05s)
resource_view_test.go:441: Unexpected OpenCensus exports (-want +got):
          []metrics.metricExtract(Inverse(Sort, []string{
        - 	"knative.dev/serving/testComponent/global_export_counts<>:2",
        - 	"knative.dev/serving/testComponent/resource_global_export_count<>:2",
        - 	`knative.dev/serving/testComponent/testing/value<project="p1",revision="r1">:0`,
        - 	`knative.dev/serving/testComponent/testing/value<project="p1",revision="r2">:1`,
          }))
    --- FAIL: TestMetricsExport/OpenCensus (4.33s)

/retest

@vagababov
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@n3wscott
Copy link
Contributor

n3wscott commented Oct 6, 2020

This will be lost when #1772 lands.

@n3wscott
Copy link
Contributor

n3wscott commented Oct 6, 2020

Flakes: #1779

Add `--kube-api-qps` and `--kube-api-burst` command-line flags
to control client QPS and Burst respectively.

The default value is set to 0 to keep backward compatibility.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@pierDipi
Copy link
Member Author

pierDipi commented Oct 7, 2020

Ref: #1672

=== CONT  TestMetricsExport/OpenCensus
    resource_view_test.go:435: Timeout reading input
    resource_view_test.go:441: Unexpected OpenCensus exports (-want +got):
          []metrics.metricExtract(Inverse(Sort, []string{
        - 	"knative.dev/serving/testComponent/global_export_counts<>:2",
        - 	"knative.dev/serving/testComponent/resource_global_export_count<>:2",
          	`knative.dev/serving/testComponent/testing/value<project="p1",rev`...,
          	`knative.dev/serving/testComponent/testing/value<project="p1",rev`...,
          }))
    --- FAIL: TestMetricsExport/OpenCensus (4.30s)

/retest

injection/config.go Outdated Show resolved Hide resolved
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020
@knative-prow-robot knative-prow-robot merged commit 1a4c99a into knative:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow override QPS and Burst via flag
6 participants