Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky tests #1673

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Conversation

vagababov
Copy link
Contributor

/assign mattmoor @evankanderson

#1672

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 31, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2020
@mattmoor
Copy link
Member

/lgtm

This flakes like crazy, and is desensitizing folks to unit test failures. Let's disable the test and investigate.

I think @yanweiguo is community oncall this week per https://github.com/knative/serving/blob/master/support/COMMUNITY_CONTACTS.md

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
metrics/resource_view.go 91.5% 86.6% -4.9

@yanweiguo
Copy link
Contributor

yanweiguo commented Aug 31, 2020

I think @yanweiguo is community oncall this week per https://github.com/knative/serving/blob/master/support/COMMUNITY_CONTACTS.md

Didn't notice that. Will pick up #1672

@knative-prow-robot knative-prow-robot merged commit a291f58 into knative:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants