-
Notifications
You must be signed in to change notification settings - Fork 270
Add include flag to export #2018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add include flag to export #2018
Conversation
Hi @thiagomedina. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thiagomedina The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiagomedina: 1 warning.
In response to this:
Description
The securityContext field is now removed from the exported service by default to improve portability.
The --include flag was added to explicitly include this field when needed.
For example:kn service export --include securityContext foo -o yaml
Since the --include flag accepts a list of values (comma-separated or repeated), it will be possible to add additional fields in the future
Changes
* Removes securityContext from exported services by default
* Add new flag(--include ) tokn service export
Reference
Close #1788
Release Note
The kn service export command now removes the securityContext field from the exported service by default to improve portability. A new --include flag was added to explicitly include this field when needed (e.g., kn service export my-service --include securityContext)
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2018 +/- ##
=======================================
Coverage 70.06% 70.07%
=======================================
Files 233 233
Lines 16464 16489 +25
=======================================
+ Hits 11535 11554 +19
- Misses 4123 4127 +4
- Partials 806 808 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
The securityContext field is now removed from the exported service by default.
The --include flag was added to explicitly include this field when needed.
For example:
kn service export --include securityContext foo -o yaml
Since the --include flag accepts a list of values (comma-separated or repeated), it will be possible to add additional fields in the future
Changes
* Removes securityContext from exported services by default
* Add new flag(--include ) to
kn service export
Reference
Close #1788
Release Note