modified channel flag to align with sink flag parsing

[EraKin575]

Description

Refactor the ChannelRef structure's Parse method to utilize the common implementation for parsing GVK formats.

Changes

*modified channel flag parsing to align with sink flag
*
*

Reference

Fixes #1871

Release Note

[knative-prow]

Welcome @EraKin575! It looks like this is your first PR to knative/client 🎉

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EraKin575
Once this PR has been reviewed and has the lgtm label, please assign vyasgun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

Hi @EraKin575. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

@EraKin575: 0 warnings.

In response to this:

Description

Refactor the ChannelRef structure's Parse method to utilize the common implementation for parsing GVK formats.

Changes

*modified channel flag parsing to align with sink flag
*
*

Reference

Fixes #1871

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dsimansk]

/ok-to-test

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.81%. Comparing base (543b2b8) to head (5e1ce9f).
Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/kn/flags/channel_types.go	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1951      +/-   ##
==========================================
- Coverage   76.82%   76.81%   -0.02%     
==========================================
  Files         207      207              
  Lines       12892    12895       +3     
==========================================
+ Hits         9904     9905       +1     
- Misses       2187     2188       +1     
- Partials      801      802       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dsimansk]

@EraKin575 thanks for the contribution and looking into the issue.

My idea from #1871 to align --channel flag with the existing parsing logic from sink. Please feel free to evaluate the code and let me know if it's possible or not. Priority is to make UX feel the same, for --sink or --channel.

https://github.com/knative/client/blob/main/pkg/kn/commands/flags/sink.go

[EraKin575]

@EraKin575 thanks for the contribution and looking into the issue.

My idea from #1871 to align --channel flag with the existing parsing logic from sink. Please feel free to evaluate the code and let me know if it's possible or not. Priority is to make UX feel the same, for --sink or --channel.

https://github.com/knative/client/blob/main/pkg/kn/commands/flags/sink.go

make it a common function for both sink and channel flags, right?

[dsimansk]

@EraKin575 thanks for the contribution and looking into the issue.
My idea from #1871 to align --channel flag with the existing parsing logic from sink. Please feel free to evaluate the code and let me know if it's possible or not. Priority is to make UX feel the same, for --sink or --channel.
https://github.com/knative/client/blob/main/pkg/kn/commands/flags/sink.go

make it a common function for both sink and channel flags, right?

Yes, exactly that.

[knative-prow-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.