Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python sdk for ormb #45

Merged
merged 2 commits into from
Jun 14, 2020
Merged

support python sdk for ormb #45

merged 2 commits into from
Jun 14, 2020

Conversation

ZhuYuJin
Copy link

What this PR does / why we need it:

[feature] Provide Python SDK

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #34

Reference to #34

Special notes for your reviewer:

/cc @gaocegege

Release note:

NONE

@caicloud-bot caicloud-bot requested a review from gaocegege June 14, 2020 07:39
@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. labels Jun 14, 2020
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM with some nits

Thanks for your contribution! 🎉 👍

extern-sdk/python/ormb/__init__.py Show resolved Hide resolved
@@ -0,0 +1 @@
requests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add version for the requirement?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2020
@caicloud-bot caicloud-bot merged commit beb0756 into kleveross:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Provide Python SDK
3 participants