fix: discard non-surface polygons during etch and grow #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The etch/grow function does not consider the masking aspect of the of the underlying geometry, resulting in non-physical operations. That is, an hermetically sealed bubble can be etched or deposited into without creating a hole in it. The operation goes through all layers, even though no `:through` argument is specified. This fix introduces a filter to discard all regions that are not connected to the surface at one point. It might break the `:through` intended behavior.
|
Hi @htherrien, I appreciate your efforts and even though it had been a while, many thanks for providing this PR. You did a great job identifying the problem and providing a fix! However, I decided not to merge it. For the motivation please see #32. No offense meant. Best regards and sorry for that, Matthias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #22 and #24
The etch/grow function does not consider the masking aspect of the of the underlying geometry, resulting in non-physical operations. That is, an hermetically sealed bubble can be etched or deposited into without creating a hole in it. The operation goes through all layers, even though no
:throughargument is specified.This fix introduces a filter to discard all regions that are not connected to the surface at one point.
It might break the
:through's intended behavior. I have not tested that parameter.