Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds StoreID field to Added to Cart and Viewed Product events #303

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Adds StoreID field to Added to Cart and Viewed Product events #303

merged 3 commits into from
Jun 13, 2024

Conversation

cykolln
Copy link
Contributor

@cykolln cykolln commented Jun 11, 2024

Description

Will allow for filtering within Klaviyo on StoreID. This matches the field that we sync on app-side events (Placed Order, Ordered Product, etc).

Manual Testing Steps

  1. Tested events using local magento instance on 2.4.6

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

@cykolln cykolln requested a review from a team as a code owner June 11, 2024 14:28
@klaviyoit klaviyoit requested a review from smoucka June 11, 2024 14:28
@cykolln cykolln merged commit 5344d12 into master Jun 13, 2024
3 checks passed
@cykolln cykolln deleted the 202406_addStoreId branch June 13, 2024 14:15
cykolln added a commit that referenced this pull request Sep 17, 2024
@cykolln
Revert "Adds StoreID field to Added to Cart and Viewed Product events (…
616f1ee 
…#303)"

This reverts commit 5344d12.
@cykolln cykolln mentioned this pull request Sep 17, 2024
Merged
cykolln added a commit that referenced this pull request Sep 24, 2024
@cykolln
Revert "Adds StoreID field to Added to Cart and Viewed Product events (…
81db8a1 
…#303)" (#311)

This reverts commit 5344d12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoucka smoucka smoucka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cykolln @smoucka