4.1.0: Remove exit command from exception index #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is failing magento's technical inspection of the 4.1.0 release. Magento security (php 7.4) restricts the usage of exit
|
You don't need to update the version here! We can roll this into 4.1.0 because it hasn't been tagged and released yet. |
cykolln
requested changes
Sep 30, 2023
jordanleslie
force-pushed
the
4.1.0_patch1
branch
from
426be6a
to
90bf196
Compare
|
@cykolln Reverted the commit! |
siddwarkhedkar
approved these changes
Oct 2, 2023
cykolln
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is failing magento's technical inspection of the 4.1.0 release. Magento security (php 7.4) restricts the usage of exit
Pre-Submission Checklist:
NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.