Merge pull request #294 from klaviyo/202403_BUGPORT-1750-m-2-extensio…

…n-4-1-2-undefined-variable-error Removes unnecessary $response var binding.
klaviyo · Mar 29, 2024 · d7621a3 · d7621a3
2 parents 7eb2261 + ca1717c
commit d7621a3
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 <!-- BEGIN RELEASE NOTES -->
 ### [Unreleased]
 
+### [4.1.3] - 2024-03-29
+
+#### Fixed
+- BUGPORT-1750: unassigned $response variable from api call during list subscription
+
 ### [4.1.2] - 2024-01-31
 
 #### Fixed
@@ -272,7 +277,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 <!-- END RELEASE NOTES -->
 <!-- BEGIN LINKS -->
-[Unreleased]: https://github.com/klaviyo/magento2-klaviyo/compare/4.1.2...HEAD
+[Unreleased]: https://github.com/klaviyo/magento2-klaviyo/compare/4.1.3...HEAD
+[4.1.3]: https://github.com/klaviyo/magento2-klaviyo/compare/4.1.2...4.1.3
 [4.1.2]: https://github.com/klaviyo/magento2-klaviyo/compare/4.1.1...4.1.2
 [4.1.1]: https://github.com/klaviyo/magento2-klaviyo/compare/4.1.0...4.1.1
 [4.1.0]: https://github.com/klaviyo/magento2-klaviyo/compare/4.0.12...4.1.0

diff --git a/Helper/Data.php b/Helper/Data.php
@@ -126,7 +126,7 @@ public function subscribeEmailToKlaviyoList($email, $firstName = null, $lastName
  )
  );
 
- $response = $api->subscribeMembersToList($listId, array($consent_profile_object));
+ $api->subscribeMembersToList($listId, array($consent_profile_object));
  } else {
  // Search for profile by email using the api/profiles endpoint
  $existing_profile = $api->searchProfileByEmail($email);
@@ -142,10 +142,7 @@ public function subscribeEmailToKlaviyoList($email, $firstName = null, $lastName
  }
  } catch (\Exception $e) {
  $this->_klaviyoLogger->log(sprintf('Unable to subscribe %s to list %s: %s', $email, $listId, $e));
- $response = false;
  }
-
- return $response;
  }
 
  /**

diff --git a/composer.dev.json b/composer.dev.json
@@ -2,7 +2,7 @@
  "name": "klaviyo/magento2-extension-dev",
  "description": "The local development composer file. This is used for local and continuous integration setup/testing.",
  "type": "magento2-module",
- "version": "4.1.2",
+ "version": "4.1.3",
  "autoload": {
  "psr-4": {
  "Klaviyo\\Reclaim\\": ""

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
  "name": "klaviyo/magento2-extension",
  "description": "Klaviyo extension for Magento 2. Allows pushing newsletters to Klaviyo's platform and more.",
  "type": "magento2-module",
- "version": "4.1.2",
+ "version": "4.1.3",
  "autoload": {
  "files": [
  "registration.php"

diff --git a/etc/module.xml b/etc/module.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
- <module name="Klaviyo_Reclaim" setup_version="4.1.2" schema_version="4.1.2">
+ <module name="Klaviyo_Reclaim" setup_version="4.1.3" schema_version="4.1.3">
  <sequence>
  <module name="Magento_Customer"/>
  <module name="Magento_Checkout"/>