Eliminate require() in favor of import #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump axios version to latest - add prepare script
deldrid1
commented
Aug 29, 2024
| @@ -1,3 +1,6 @@ | |||
| import querystring from 'querystring'; | |||
There was a problem hiding this comment.
tree-shaking should take care of ignoring unused modules. These are native anyway, so I don't see any reason to do a complicated runtime import.
There was a problem hiding this comment.
There's also no benefit of prefixing with node: to my knowledge - I left it out for compatibility as I didn't feel like studying config files to understand what is appropriate here :)
|
Thank you for your contribution! Due to the way we develop our SDKs, we'll need to make this change in a different internal repo. We will update this thread when it is pulled in and released! |
|
meant to mention, for now im going to close the pull request for internal tracking purposes |
|
That's what I figured. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some legacy
require()'s and runtime imports littered in the code base that were causing issues with Webpack (TypeError: axios is not a functionat runtime) in a large ESM node 20 project that still includes some CommonJS package dependencies. I suspect it may help address #53I don't expect it to be merged as is (I haven't updated the version or anything), but wanted to put it here in case the team wants to pull it in!
In addition to replacing
requirewithimport, this PR also:node_modules/klaviyo-node-apifolder has adistfolder