Time Point 1-6 start changed to select insttead of numbers #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the numbers: "Time Point [1-6] start and created selects for them instead. added support for every half hour. Modbus adresses is: 148 - 153
|
@tobenski I'm happy to accept this MR on deye-sun-12k-sg04lp3.yaml |
|
@tobenski merged to my deye config philipphenkel/esphome-config@7809ebd |
luckylinux
pushed a commit
to luckylinux/esphome-for-deye
that referenced
this pull request
Apr 4, 2024
|
@tobenski I'm also happy to accept this in my fork with a more modular approach. Merged in luckylinux/esphome-for-deye@4952ace Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the numbers: "Time Point [1-6] start
and created selects for them instead.
added support for every half hour.
Modbus adresses is: 148 - 153