instruction table: implement trace_evaluation
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmalatrax
reviewed
Nov 21, 2024
| ); | ||
|
|
||
| // Check that each column contains the correct values | ||
| assert_eq!(trace[InstructionColumn::Ip.index()].to_cpu().values[0], BaseField::from(1)); |
There was a problem hiding this comment.
We should compare values rather than values[0]
There was a problem hiding this comment.
done, as this test is simple, I've directly hardcoded 16, the expected number of elements, let me know if this is ok for you
tcoratger
commented
Nov 21, 2024
tcoratger
commented
Nov 21, 2024
tcoratger
commented
Nov 21, 2024
zmalatrax
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.