[Do Not Merge] Add Meter Tags, Instrument Tags, and Scopes to System Diagnostics Metrics #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Note that this operates under the assumption of unique meter names
wiktork
reviewed
Nov 17, 2023
|
|
||
| char separator = IsMeter(metric) ? '=' : ':'; | ||
| var metadataValues = CounterUtilities.GetMetadata(metadata, separator); | ||
| var metadataValues = CounterUtilities.GetMetadata(allMetadata, separator); |
There was a problem hiding this comment.
So for prometheus export, we will effectively combine meter, instrument, and instance tags into one set correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR goes along with dotnet/diagnostics#4324 in the diagnostics repo.
This PR adds meter tags, instrument tags, and scopes to System Diagnostics Metrics. There is currently a limitation (see dotnet/runtime#93097) around having multiple providers with the same name. As a result, this PR currently makes the assumption that all meters have unique names.
Quick note - this PR is currently targeting the unification branch, but shouldn't be merged into main until that PR has been merged.
Closes dotnet#5140
Release Notes Entry
Add Support for Meter Tags and Instrument Tags for System Diagnostics Metrics.