Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #127: Reopening last article via double clicking on menu items/refreshing when double clicking on home #1284

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

D3V-D
Copy link
Contributor

@D3V-D D3V-D commented Nov 4, 2024

Closes #127

Works in npm run serve and passes npm run test. Also works in both ServiceWorker and restricted modes.

Works fine in Firefox & Chromium for me, I do not have edge to test that so some help there would be much appreciated!

Also, if you could check npm run preview for me as the changes are not reflected for me, that'd be great.

Should be completely keyboard compatible

@D3V-D
Copy link
Contributor Author

D3V-D commented Nov 4, 2024

@Jaifroid Please review when you have the time, thanks!

@D3V-D D3V-D changed the title Reopening last article via double clicking on menu items/refreshing when double clicking on home Closes #127: Reopening last article via double clicking on menu items/refreshing when double clicking on home Nov 4, 2024
@Jaifroid
Copy link
Member

Jaifroid commented Nov 4, 2024

Great, thanks for the PR! I'm currently at work, but will look at this as soon as I can.

@Jaifroid
Copy link
Member

Jaifroid commented Nov 4, 2024

I got a few minutes to test your implementation with npm run preview, and I'm happy to report it builds and opens fine in that view (for me), and is working really well. 😀 No problems in Edge. Congratulations!

You can also build the minified distribution and open it in http-server like this:

npm run build-min
npm run web-server

Then go to http://localhost:8080/dist/www/index.html in your browser. If you need to disable App Cache in that view, you can also add ?appCache=false to the end of the URL in your browser. This all works fine for me.

If you need to refresh the app in your browser, then make sure App Cache is disabled, open dev tools, make sure browser caching is turned off in dev tools, and then hard-refresh with Ctrl-Shift-R (or Mac equivalent). I have noticed that on Firefox even this sometimes fails to refresh code, and the only solution then is to exit the browser and then re-load the page. On Chromium browsers I've found this procedure always loads the latest code. The key is to refresh with dev tools open in the browser, and browser caching disabled in dev tools.

It'll take a bit more time to review the code itself, but I'll do it as soon as I can.

@Jaifroid Jaifroid self-requested a review November 4, 2024 14:49
@D3V-D
Copy link
Contributor Author

D3V-D commented Nov 4, 2024

No rush, thanks for taking the time to test the preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reopen the last article after switching between menu items
2 participants