Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DispatchQueues with async Tasks #987

Merged

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #986

Replace older DispatchQueue solutions with newer async Tasks, so we do not mix concurrency solutions, which is not recommended by Apple.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 39.62%. Comparing base (c32dc36) to head (884bb8a).

Files with missing lines Patch % Lines
ViewModel/BrowserViewModel.swift 0.00% 7 Missing ⚠️
Model/DownloadService.swift 0.00% 2 Missing ⚠️
Views/SearchResults.swift 0.00% 1 Missing ⚠️
Views/ViewModifiers/FileImport.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
+ Coverage   39.52%   39.62%   +0.10%     
==========================================
  Files         113      112       -1     
  Lines        6444     6425      -19     
==========================================
- Hits         2547     2546       -1     
+ Misses       3897     3879      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BPerlakiH BPerlakiH force-pushed the 986-use-modern-swift-concurrency-through-out-the-project branch from ab7d9af to 28ff6b4 Compare September 21, 2024 11:55
Base automatically changed from 861-library-loading-is-blocking-the-main-thread to main September 21, 2024 13:39
@BPerlakiH BPerlakiH force-pushed the 986-use-modern-swift-concurrency-through-out-the-project branch from 28ff6b4 to 1d54b1c Compare September 21, 2024 13:46
@BPerlakiH BPerlakiH linked an issue Sep 21, 2024 that may be closed by this pull request
@kelson42 kelson42 force-pushed the 986-use-modern-swift-concurrency-through-out-the-project branch from 1d54b1c to 884bb8a Compare September 21, 2024 14:15
@kelson42 kelson42 merged commit 784bb96 into main Sep 21, 2024
4 checks passed
@kelson42 kelson42 deleted the 986-use-modern-swift-concurrency-through-out-the-project branch September 21, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use modern swift concurrency through out the project
3 participants