-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opening app with ZIM doesn't open ZIM #968
Fix opening app with ZIM doesn't open ZIM #968
Conversation
@rgaudin Are you able to review/test before merging? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
+ Coverage 37.07% 39.13% +2.06%
==========================================
Files 110 110
Lines 6314 6311 -3
==========================================
+ Hits 2341 2470 +129
+ Misses 3973 3841 -132 ☔ View full report in Codecov by Sentry. |
Tested, works like a charm: opening a ZIM if Kiwix if not open opens Kiwix with single window of said ZIM. When opening a ZIM while Kiwix is open, it add a window with said ZIM. |
We should have only one window. It ahould not open a new window, it should open a new tab in existing window. |
This is following Apple's UI guidelines |
This multi windows is going to endlessly create problems. I will open an issue to stop this. |
This is how macOS apps behave and are expected to behave. We surely can force a single window but that's at the expense of the user experience. |
Fixes: #962
As mentioned in the ticket description, the easiest way to fix this issue is to disable the non-working window restore solution on macOS.
Testing: Make sure you have only 1 version of Kiwix installed. It is possible to have multiple of them (eg from: AppStore, TestFlight, local build).
and as of Apple docs:
meaning that the clicked ZIM file might open in another version of Kiwix, if you have more than 1 installed.