Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

933 iphone video starts in full screen #936

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

BPerlakiH
Copy link
Collaborator

@BPerlakiH BPerlakiH commented Aug 18, 2024

Fixes: #933

Note it is based on the PR: #924

Solution:

As of Apple's doc, we need to set:
allowsinlinemediaplayback
and additionally set:
mediaTypesRequiringUserActionForPlayback - otherwise it's not working
and we need to enforce that there's a playsinline attribute on the html <video>.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.17%. Comparing base (18acd0b) to head (986785b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
+ Coverage   39.13%   39.17%   +0.03%     
==========================================
  Files          99       99              
  Lines        5353     5356       +3     
==========================================
+ Hits         2095     2098       +3     
  Misses       3258     3258              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BPerlakiH BPerlakiH force-pushed the 933-iphone-video-starts-in-full-screen branch from bfa823b to 00ec0cc Compare August 18, 2024 18:23
Base automatically changed from 916-iphone-video-starts-with-a-black-screen to main August 19, 2024 11:28
@kelson42 kelson42 force-pushed the 933-iphone-video-starts-in-full-screen branch from 00ec0cc to d125acc Compare August 19, 2024 11:29
@BPerlakiH BPerlakiH linked an issue Aug 19, 2024 that may be closed by this pull request
Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BPerlakiH With the two files reported in the issue, playsinline is available so this is not the root cause of this issue. As such and because we should not modify the DOM, I believe this part of the patch is not wanted. @rgaudin What do you think?

@rgaudin
Copy link
Member

rgaudin commented Aug 19, 2024

Noticed this as well but since it's a requirement for it to work, I think it's good to keep it.

@kelson42 kelson42 force-pushed the 933-iphone-video-starts-in-full-screen branch from d125acc to 986785b Compare August 19, 2024 11:39
@kelson42 kelson42 merged commit 52a74c9 into main Aug 19, 2024
3 of 4 checks passed
@kelson42 kelson42 deleted the 933-iphone-video-starts-in-full-screen branch August 19, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPhone video starts in full screen
4 participants