-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
933 iphone video starts in full screen #936
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
==========================================
+ Coverage 39.13% 39.17% +0.03%
==========================================
Files 99 99
Lines 5353 5356 +3
==========================================
+ Hits 2095 2098 +3
Misses 3258 3258 ☔ View full report in Codecov by Sentry. |
bfa823b
to
00ec0cc
Compare
00ec0cc
to
d125acc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BPerlakiH With the two files reported in the issue, playsinline
is available so this is not the root cause of this issue. As such and because we should not modify the DOM, I believe this part of the patch is not wanted. @rgaudin What do you think?
Noticed this as well but since it's a requirement for it to work, I think it's good to keep it. |
d125acc
to
986785b
Compare
Fixes: #933
Note it is based on the PR: #924
Solution:
As of Apple's doc, we need to set:
allowsinlinemediaplayback
and additionally set:
mediaTypesRequiringUserActionForPlayback
- otherwise it's not workingand we need to enforce that there's a
playsinline
attribute on the html<video>
.