Dynamic link for Rate the App #564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvision251
reviewed
Nov 28, 2023
| @@ -216,7 +216,8 @@ struct Settings: View { | |||
| Section("Misc".localized) { | |||
| Button("Feedback".localized) { UIApplication.shared.open(URL(string: "mailto:[email protected]")!) } | |||
| Button("Rate the App".localized) { | |||
| let url = URL(string: "itms-apps://itunes.apple.com/us/app/kiwix/id997079563?action=write-review")! | |||
There was a problem hiding this comment.
@BPerlakiH Please replace the App store ID using Brand.appstoreId
There was a problem hiding this comment.
@tvision251 I am not sure if I understand your point here.
With these changes the value from Brand.appStoreId is used.
|
@BPerlakiH can you please rebase on git main head? |
tvision251
approved these changes
Nov 28, 2023
|
this PR not to be merged directly |
|
No longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #554
Blocked by #520