-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matplotlib 3.8 update event issue fix #3
Matplotlib 3.8 update event issue fix #3
Conversation
self.entered_figure = False | ||
|
||
def enter_notify_event(self, guiEvent=None, xy=None): | ||
event = Event("figure_enter_event", self, guiEvent) | ||
def enter_notify_event(self, gui_event=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are making the API backward-incompatible, but since we're moving to a new package, that's also an opportunity to clean up bad things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted. Didn't think of that, thanks for the hint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not had the chance to test it on runtime (yet), but LGTM.
Thank you!
Since you already digged into it, do you mind adding some docs and examples, so we can start the release process for this flower?
it is possible that the old api has been deprecated for a while, and the new API may have been supported for a while. I just need to learn how to install a non-legacy flower |
This should fix issue #1 and #2.