Matplotlib 3.8 update event issue fix #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misl6
reviewed
Dec 28, 2023
| self.entered_figure = False | ||
|
|
||
| def enter_notify_event(self, guiEvent=None, xy=None): | ||
| event = Event("figure_enter_event", self, guiEvent) | ||
| def enter_notify_event(self, gui_event=None): |
There was a problem hiding this comment.
These changes are making the API backward-incompatible, but since we're moving to a new package, that's also an opportunity to clean up bad things.
There was a problem hiding this comment.
Well spotted. Didn't think of that, thanks for the hint.
misl6
approved these changes
Dec 28, 2023
|
it is possible that the old api has been deprecated for a while, and the new API may have been supported for a while. I just need to learn how to install a non-legacy flower |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #1 and #2.