-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package project, so it can be installed via pip #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @g-braeunlich,
Great change. I especially appreciate the MathTextParser
fix, that's been bugging me and I almost submitted a PR myself.
Doing a pip install would be a lot easier than relying on the legacy flower format.
I tried out the toml
file and it worked on my machine, with a warning.
The only problem is that I think this approach breaks the guidance outlined in the kivy garden docs. The docs state that repos must be archived when upgrading the flower format.
I don't know the exact reasoning behind this rule, but it might have to do with the ambiguous absolute import. If this flower is installed using the legacy format then the import statement is kivy.garden.matplotlib
. If the flower is installed using pip
then the import statement is kivy_garden.matplotlib
.
If one of the maintainers approves this approach, then I have a one more comment:
- The example
py
files are now broken. You'll need to fix the import statements for them to work with pip.
Thanks a lot for your comments. In this case, I am going to request a new repo and will attempt to migrate it there properly. |
Request submitted here: kivy-garden/kivy-garden.github.io#162 |
Also updated my commits, so the examples work |
Hi @g-braeunlich ! Thank you for the friendly ping about this one. Can you please consider proposing the changes again when the new repo is ready? |
Hi @g-braeunlich, Please let me know if your PR addresses my Issue kivy-garden/matplotlib#1, which finds a breaking change for matplotlib 3.8.0. Please note that kivy-ios uses matplotlib 3.7.2 and android uses 3.5.2. |
@g-braeunlich , @Joshua-Douglas , @tcaduser : The matplotlib flower has been moved to https://github.com/kivy-garden/matplotlib . (I will slowly move all the still valid issues to the new repo, ASAP) Feel free to submit your PRs from now on. |
@tcaduser My PR does not address your issue. However chances are that my colleague solved that issue. |
See https://kivy.org/doc/stable/api-kivy.garden.html