[MAINTENANCE] Add tests for Controller package #954
32 new security issues (0 max.).
Here is an overview of what got changed by this pull request:
Issues
======
- Added 57
Complexity increasing per file
==============================
- Tests/Functional/Controller/SearchControllerTest.php 1
- Tests/Functional/Controller/CalendarControllerTest.php 1
- Tests/Functional/Controller/CollectionControllerTest.php 1
- Tests/Functional/Controller/PageViewControllerTest.php 1
- Tests/Functional/Controller/TableOfContentsControllerTest.php 1
- Tests/Functional/Controller/FeedsControllerTest.php 1
- Tests/Functional/Controller/ToolboxControllerTest.php 1
- Tests/Functional/Controller/AbstractControllerTest.php 3
- Tests/Functional/Controller/NavigationControllerTest.php 1
- Tests/Functional/Controller/ListViewControllerTest.php 1
- Tests/Functional/Controller/MetadataControllerTest.php 1
- Tests/Functional/Controller/PageGridControllerTest.php 1
- Tests/Functional/Controller/StatisticsControllerTest.php 1
- Tests/Functional/Controller/AudioPlayerControllerTest.php 1
Complexity decreasing per file
==============================
+ Tests/Functional/Common/SolrSearchQueryTest.php -1
+ Tests/Functional/Common/SolrSearchTest.php -1
+ Tests/Functional/Common/SolrTest.php -1
See the complete overview on Codacy
Annotations
Check warning on line 50 in Tests/Functional/Controller/AbstractControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/AbstractControllerTest.php#L50
Avoid unused parameters such as '$uid'.
Check notice on line 100 in Tests/Functional/Controller/AbstractControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/AbstractControllerTest.php#L100
The closing brace for the class must go on the next line after the body
Check notice on line 19 in Tests/Functional/Controller/AudioPlayerControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/AudioPlayerControllerTest.php#L19
Visibility must be declared on property "$databaseFixtures"
Check notice on line 21 in Tests/Functional/Controller/CalendarControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/CalendarControllerTest.php#L21
Visibility must be declared on property "$databaseFixtures"
Check notice on line 18 in Tests/Functional/Controller/CollectionControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/CollectionControllerTest.php#L18
Opening brace of a class must be on the line after the definition
Check notice on line 18 in Tests/Functional/Controller/CollectionControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/CollectionControllerTest.php#L18
Opening brace of a class must be on the line after the definition
Check notice on line 20 in Tests/Functional/Controller/CollectionControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/CollectionControllerTest.php#L20
Visibility must be declared on property "$databaseFixtures"
Check notice on line 25 in Tests/Functional/Controller/CollectionControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/CollectionControllerTest.php#L25
Visibility must be declared on property "$solrFixtures"
Check notice on line 20 in Tests/Functional/Controller/FeedsControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/FeedsControllerTest.php#L20
Visibility must be declared on property "$databaseFixtures"
Check failure on line 43 in Tests/Functional/Controller/MetadataControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/MetadataControllerTest.php#L43
Direct use of $_POST Superglobal detected.
Check notice on line 23 in Tests/Functional/Controller/NavigationControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/NavigationControllerTest.php#L23
Visibility must be declared on property "$databaseFixtures"
Check failure on line 40 in Tests/Functional/Controller/NavigationControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/NavigationControllerTest.php#L40
Direct use of $_POST Superglobal detected.
Check failure on line 49 in Tests/Functional/Controller/NavigationControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/NavigationControllerTest.php#L49
Direct use of $GLOBALS Superglobal detected.
Check failure on line 49 in Tests/Functional/Controller/NavigationControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/NavigationControllerTest.php#L49
Direct use of $GLOBALS Superglobal detected.
Check notice on line 19 in Tests/Functional/Controller/PageViewControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/PageViewControllerTest.php#L19
Visibility must be declared on property "$databaseFixtures"
Check failure on line 36 in Tests/Functional/Controller/PageViewControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/PageViewControllerTest.php#L36
Direct use of $_POST Superglobal detected.
Check failure on line 43 in Tests/Functional/Controller/SearchControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/SearchControllerTest.php#L43
Direct use of $_POST Superglobal detected.
Check failure on line 43 in Tests/Functional/Controller/SearchControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/SearchControllerTest.php#L43
Direct use of $_POST Superglobal detected.
Check failure on line 46 in Tests/Functional/Controller/SearchControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/SearchControllerTest.php#L46
Direct use of $_POST Superglobal detected.
Check notice on line 17 in Tests/Functional/Controller/StatisticsControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/StatisticsControllerTest.php#L17
Opening brace of a class must be on the line after the definition
Check notice on line 17 in Tests/Functional/Controller/StatisticsControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/StatisticsControllerTest.php#L17
Opening brace of a class must be on the line after the definition
Check notice on line 19 in Tests/Functional/Controller/StatisticsControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/StatisticsControllerTest.php#L19
Visibility must be declared on property "$databaseFixtures"
Check failure on line 36 in Tests/Functional/Controller/StatisticsControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/StatisticsControllerTest.php#L36
Direct use of $GLOBALS Superglobal detected.
Check failure on line 36 in Tests/Functional/Controller/StatisticsControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/StatisticsControllerTest.php#L36
Direct use of $GLOBALS Superglobal detected.
Check failure on line 36 in Tests/Functional/Controller/ToolboxControllerTest.php
codacy-production / Codacy Static Code Analysis
Tests/Functional/Controller/ToolboxControllerTest.php#L36
Direct use of $_POST Superglobal detected.