Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Remove client-side paging redundancies #938

Draft
wants to merge 78 commits into
base: master
Choose a base branch
from
Draft

[FEATURE] Remove client-side paging redundancies #938

wants to merge 78 commits into from
+2,199 −321

Commits on Aug 1, 2024

  1. Add explanation about addHighlightField method

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0f473ef View commit details
    Browse the repository at this point in the history

  2. Add Basic JSON Representation for Document and First Navigation Button

    @beatrycze-volk
    Matthias Richter authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6ce1255 View commit details
    Browse the repository at this point in the history

  3. Refactor: Format code 

    - Remove unused import
- Replace tabs with spaces
    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0eaeeb0 View commit details
    Browse the repository at this point in the history

  4. Refactor: Move JS from template to new Navigation.js

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    30da335 View commit details
    Browse the repository at this point in the history

  5. Make loaded document a global variable 

    This will allow the navigation plugin to access the document, e.g., to
get the number of pages.
    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c2fa5d9 View commit details
    Browse the repository at this point in the history

  6. Fix naming pageBack vs. pageStepBack

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    be80aab View commit details
    Browse the repository at this point in the history

  7. Handle all forward/back navigation buttons

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0e84acf View commit details
    Browse the repository at this point in the history

  8. Enable/disable nav buttons on client, + refactor

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3f92a0a View commit details
    Browse the repository at this point in the history

  9. Create WIP documentation page

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d490a10 View commit details
    Browse the repository at this point in the history

  10. Include page object in pageChanged event, start typing

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    e41ba10 View commit details
    Browse the repository at this point in the history

  11. Update metadata table on page change

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    51301f2 View commit details
    Browse the repository at this point in the history

  12. Add Data Structure for Client Side Fulltext Reload

    @beatrycze-volk
    Matthias Richter authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    20ec213 View commit details
    Browse the repository at this point in the history

  13. Adapt Fulltext Datastructure to Metadata and Document

    @beatrycze-volk
    Matthias Richter authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    48c1be1 View commit details
    Browse the repository at this point in the history

  14. Update navigation select

    @beatrycze-volk
    beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3126339 View commit details
    Browse the repository at this point in the history

  15. Update links for navigation buttons

    @beatrycze-volk
    beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    86f2c7a View commit details
    Browse the repository at this point in the history

  16. Fix reference to fulltextControl

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    cbff479 View commit details
    Browse the repository at this point in the history

  17. Set navigation select value on page change

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    691cb46 View commit details
    Browse the repository at this point in the history

  18. Fix: First load data in Doc::getLogicalSectionsOnPage

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    dfe0392 View commit details
    Browse the repository at this point in the history

  19. Start implementing history/browser navigation

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ac06bcf View commit details
    Browse the repository at this point in the history

  20. Refactor: In document JSON, store pages in subkey

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f7624a8 View commit details
    Browse the repository at this point in the history

  21. Refactor: Wrap image URL & MIME type into subkey

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    63aa6c5 View commit details
    Browse the repository at this point in the history

  22. Extract Doc::getPageLink() 

    Prepare listing download URLs in document JSON
    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    33f0206 View commit details
    Browse the repository at this point in the history

  23. List download URLs in document JSON

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6fbf835 View commit details
    Browse the repository at this point in the history

  24. Update page download links on page change

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1d21c59 View commit details
    Browse the repository at this point in the history

  25. Refactor: Avoid manual JSON encoding

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c7149f8 View commit details
    Browse the repository at this point in the history

  26. Include all file groups/URLs in document JSON 

    Prepare to migrate the image download tool, which uses a configurable
file group.
    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    fbf571f View commit details
    Browse the repository at this point in the history

  27. Update image download links on page change

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7f7f50c View commit details
    Browse the repository at this point in the history

  28. Start implementing client-side double page mode 

    - Consider in pageview, toolbox, navigation, metadata
- Allow toggling single page / double page without page reload
    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b976676 View commit details
    Browse the repository at this point in the history

  29. Simplify: Remove pageObj and target from event detail

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d1c302e View commit details
    Browse the repository at this point in the history

  30. Simplify: Merge pageChanged and configChanged events

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    a71742d View commit details
    Browse the repository at this point in the history

  31. Fix back buttons when using route enhancers

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b241a59 View commit details
    Browse the repository at this point in the history

  32. Generalize URL generation to work with slugs

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5923985 View commit details
    Browse the repository at this point in the history

  33. Fix pdf and image download links

    @beatrycze-volk
    Matthias Richter authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    de9eeb0 View commit details
    Browse the repository at this point in the history

  34. TOC: Add option to render full table of contents

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5ad4b40 View commit details
    Browse the repository at this point in the history

  35. Add client side navigation from table of contents

    @beatrycze-volk
    Matthias Richter authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    a615e96 View commit details
    Browse the repository at this point in the history

  36. Add separate marker for metadata list

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b40dccf View commit details
    Browse the repository at this point in the history

  37. Start implementing dynamic TOC expansion

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    029aa23 View commit details
    Browse the repository at this point in the history

  38. Update URL on page change

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    474e40d View commit details
    Browse the repository at this point in the history

  39. Optimize document JSON generation for METS 

    The `xpath()` calls in `getFileLocation` and `getFileMimeType` seem to
be slow, which has been quite noticeable in documents that contain many
files.
    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    2f85789 View commit details
    Browse the repository at this point in the history

  40. Fix disabling of lastPage navigation button

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    2f535f7 View commit details
    Browse the repository at this point in the history

  41. Cache pageview layers

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6b00732 View commit details
    Browse the repository at this point in the history

  42. Update Page URL Template for Use with Page Grid

    @beatrycze-volk
    Matthias Richter authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6286c63 View commit details
    Browse the repository at this point in the history

  43. Add document plugin for JSON representation

    @beatrycze-volk
    Matthias Richter authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7dd4391 View commit details
    Browse the repository at this point in the history

  44. Move document initialisation to document plugin

    @beatrycze-volk
    Matthias Richter authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3b03dc1 View commit details
    Browse the repository at this point in the history

  45. Move document handling to dlfController via event

    @beatrycze-volk
    Matthias Richter authored and beatrycze-volk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    70d24e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Start moving getVisiblePages to dlfController

    @beatrycze-volk
    Matthias Richter authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    cb2f04b View commit details
    Browse the repository at this point in the history

  2. Use getVisiblePages() of dlfController

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    dbfa82a View commit details
    Browse the repository at this point in the history

  3. Refactor: Extract dlfController::eventTarget

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0030c3c View commit details
    Browse the repository at this point in the history

  4. Refactor: Don't dispatch stateChanged manually

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    85213aa View commit details
    Browse the repository at this point in the history

  5. Refactor: Dissolve global tx_dlf_loaded

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    5beac28 View commit details
    Browse the repository at this point in the history

  6. [EXT] Reinstate registry

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d2e57fd View commit details
    Browse the repository at this point in the history

  7. [EXT] Memoize MetsDocument::getStructureDepth()

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0f4d27e View commit details
    Browse the repository at this point in the history

  8. Fetch prerendererd metadata dynamically 

    On large documents, rendering metadata of all sections can take a
considerable amount of time.

Instead, allow to just render the current metadata, and fetch the
additional metadata in an API call.
    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    9277a7c View commit details
    Browse the repository at this point in the history

  9. Convert TODO to TODO(client-side)

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    155043e View commit details
    Browse the repository at this point in the history

  10. Update and extend documentation

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    024a677 View commit details
    Browse the repository at this point in the history

  11. Update .editorconfig (4 spaces for JS) to reflect actual use

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6a4c8d0 View commit details
    Browse the repository at this point in the history

  12. Extend documentation

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    f1598ee View commit details
    Browse the repository at this point in the history

  13. Add and update notes about URL generation

    @beatrycze-volk
    Kajetan Dvoracek authored and beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    69703f1 View commit details
    Browse the repository at this point in the history

  14. Fix Codacy warnings

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    aa320e4 View commit details
    Browse the repository at this point in the history

  15. Fix toArray method in Doc class 

    - remove dead variables
- fix check for mime type
    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4374ffe View commit details
    Browse the repository at this point in the history

  16. Adjust DocumentController

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c0ceca2 View commit details
    Browse the repository at this point in the history

  17. Move nonProxyMimeTypes to config

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8392ccf View commit details
    Browse the repository at this point in the history

  18. Implement getAllFiles for IIIFManifest

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d226b02 View commit details
    Browse the repository at this point in the history

  19. Remove unused manifest variable

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    cdd288d View commit details
    Browse the repository at this point in the history

  20. Fix intend in css

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e03c0f8 View commit details
    Browse the repository at this point in the history

  21. Improve Metadata script 

    - removed unused e param from onStateChanged
- make fetchMetadata async so no spinner is needed
    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c8e28fb View commit details
    Browse the repository at this point in the history

  22. Improve Navigation script 

    - remove unused paramaters
- decrease complexity of updateNavigationControls
    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    40f536b View commit details
    Browse the repository at this point in the history

  23. Assign fulltextEntry directly

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d31dbd9 View commit details
    Browse the repository at this point in the history

  24. Fix comment

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    41301cf View commit details
    Browse the repository at this point in the history

  25. Allow console logs

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    48e96b6 View commit details
    Browse the repository at this point in the history

  26. Activate full text highlight if full text is active

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4704970 View commit details
    Browse the repository at this point in the history

  27. Fix errors marked by PHPStan

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8f8ae48 View commit details
    Browse the repository at this point in the history

  28. Fix Codacy errors

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3ac619d View commit details
    Browse the repository at this point in the history

  29. Fix error: Direct use of $GLOBALS Superglobal detected

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    1f62fc1 View commit details
    Browse the repository at this point in the history

  30. Fix documentation build 

    Error:  `Inventory link with key "t3tsref:data-type-page-id" (data-type-page-id) not found.`
    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3bdcb82 View commit details
    Browse the repository at this point in the history

  31. Fix PHPStan warnings

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d647e5f View commit details
    Browse the repository at this point in the history

  32. Remove initDoc to avoid redundancy between Document and PageView cont… 

    …rollers

Logically the document should not be displayed if its controller is not loaded
    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    cd32212 View commit details
    Browse the repository at this point in the history

  33. Display toolbox initialization only once

    @beatrycze-volk
    beatrycze-volk committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    fea6f47 View commit details
    Browse the repository at this point in the history