Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Filter array for empty search parameters #1411

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

beatrycze-volk
Copy link
Collaborator

No description provided.

@sebastian-meyer sebastian-meyer added the 🛠 maintenance A task to keep the code up-to-date and manageable. label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c7c7839) to head (3feb18e).

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #1411   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beatrycze-volk
Copy link
Collaborator Author

PHPStan error is a bit questionable: phpstan/phpstan#2266

I will think about it.

@beatrycze-volk beatrycze-volk marked this pull request as draft December 19, 2024 11:14
@sebastian-meyer
Copy link
Member

I'd be fine with adding this to the ignored errors in .github/phpstan.neon.

@sebastian-meyer sebastian-meyer self-requested a review December 20, 2024 13:16
@beatrycze-volk beatrycze-volk force-pushed the searchparams branch 2 times, most recently from a4bf6c1 to 89b97d2 Compare December 23, 2024 18:05
@beatrycze-volk beatrycze-volk marked this pull request as ready for review December 30, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants