Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Call sanitizeSettings function in loadDocument of AbstractController #1334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beatrycze-volk
Copy link
Collaborator

I have forgotten push last commit from branch in #1324

Closes #1329

@beatrycze-volk
Copy link
Collaborator Author

4 tests with failures will be gone after #1330 is merged

8 tests with errors are coming from OaiPmhTest class and are probably related to setting of default values. There is possibility that those tests were actually depending on missing settings and now when those settings are there it cause problem. I will look into it,

@beatrycze-volk
Copy link
Collaborator Author

Logger can be accessed in constructor if this feature will be implemented: https://docs.typo3.org/m/typo3/reference-coreapi/11.5/en-us/ApiOverview/Logging/Logger/Index.html#instantiation

@beatrycze-volk beatrycze-volk changed the title [BUGFIX] Call sanitizeSettings function in initialize of AbstractController [BUGFIX] Call sanitizeSettings function in loadDocument of AbstractController Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] setCPid() must be of the type int, null given
1 participant