-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] General reusable validation implementation and middleware for validating DOMDocument #1313
Open
markusweigelt
wants to merge
47
commits into
kitodo:master
Choose a base branch
from
markusweigelt:xml-validator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusweigelt
changed the title
[FEATURE] Validation
[FEATURE] General reusable validation implementation and middleware for validating DOMDocument
Aug 29, 2024
10 tasks
sebastian-meyer
requested changes
Sep 9, 2024
Comment on lines
90
to
93
To learn about available options (e.g., to select the PHP version), check the usage info: | ||
|
||
```bash | ||
Build/Test/runTests.sh -h | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the removed command this makes no more sense. Was the removal intentional? Then this should be removed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides abstract classes to derived from for custom validation and reusable implementations for validation of DOMDocument.
AbstractValidator
of Extbase)DOMDocumentValidationStack
,XMLSchemesValidator
andSaxonXslToSvrlValidator
DOMDocumentValidation
middleware via TypoScript settingdomDocumentValidationValidators
Example of middleware
URI Query:
dlf/domDocumentValidation&url=https%3A%2F%2Fwww.example.com%2Fmetsmods.xml
JSON response