Do not unset DynamoDB Client on disconnect until implement reconnect …

…method.
kitar · Nov 17, 2021 · 602be30 · 602be30
1 parent 524180e
commit 602be30
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/Kitar/Dynamodb/Connection.php b/src/Kitar/Dynamodb/Connection.php
@@ -91,7 +91,8 @@ protected function createClient(array $config)
 
         if (isset($config['key']) && isset($config['secret'])) {
             $dynamoConfig['credentials'] = Arr::only(
-                $config, ['key', 'secret', 'token']
+                $config,
+                ['key', 'secret', 'token']
             );
         }
 
@@ -103,9 +104,7 @@ protected function createClient(array $config)
      */
     public function disconnect()
     {
-        unset($this->client);
-
-        $this->client = null;
+        //
     }
 
     /**

diff --git a/tests/ConnectionTest.php b/tests/ConnectionTest.php
@@ -50,11 +50,11 @@ public function it_returns_driver_name()
     }
 
     /** @test */
-    public function it_destroys_connection()
+    public function it_keeps_dynamodb_client_on_disconnect()
     {
         $this->connection->disconnect();
 
-        $this->assertNull($this->connection->getClient());
+        $this->assertNotNull($this->connection->getClient());
     }
 
     /** @test */