Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Share Button in Popup Menu an Action #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheJackTenor
Copy link
Contributor

@TheJackTenor TheJackTenor commented Feb 19, 2018

TODO :

  • Adding new libarary (React-Native-Share).
  • Adding function to share button in popup menu to share the content's URL to user's supported app
    screenshot_2018-02-19-10-05-51-179_android
    Thanks

} from 'react-native-popup-menu';

import Share from 'react-native-share';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to add this to the package.json

@kiok46
Copy link
Owner

kiok46 commented Feb 21, 2018

Hey, @TheJackTenor Thanks for the PR, looks good. please make the requested change.

@TheJackTenor
Copy link
Contributor Author

@kiok46 Oh, i'm really sorry about that. Wait a minute.

@kiok46
Copy link
Owner

kiok46 commented Feb 26, 2018

Hey, @TheJackTenor This doesn't seem to work on Android. (Pixel2)

@MathewtheCoder
Copy link

@kiok46 Is this done or can i pick this up ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants