[pull] master from digitalbitbox:master #294
Open
+471,579
−543,682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Adds an info button next to the BTC Direct info message with further details about the OTC service. The BTC Direct link will either route to a new internal BTC Direct page showing the disclaimer or to the external page, depending on whether the disclaimer has been accepted.
3d1603c added frontend support for BtCDirect integration, but that was relying on pocket bitcoin regional availabilities to display the BtcDirect informative panel. This commit adds proper backend support. The BtcDirect panel is now also shown in case of failure of the `getExchangeDeals` call or payment request errors.
The app currently accepts dropping files into the app window and tries to render those. This will error with a blocked error without any way to go back making the app unusable. Added a hook to globally ignore dropped files.
Reduced from 10 vulnerabilities (8 low, 1 moderate, 1 high) to 8 low severity vulnerabilities.
This downgraded wallet-connect by 1 patch version
The estimate (≈) symbol should be placed before the amount and sign
separated by a white-space.
Example:
≈ +100.-
The Android back button stopped working after the back button was used to close a dialog. The reason is that the backbutton pop handler did not remove the handler, as `slice(index, 1)` does not remove the element at `index`, it in fact keeps it. When properly removing the handler, back button behavior works as expected again.
The auth screen was sometimes showed for a very short time at startup even when it was disabled. This fixes the glitch, hiding the auth screen details while the backend checks if the auth config is enabled.
The "No priority" option has been removed because it can be confusing for users, and selecting it during high fee times can cause transactions to get stuck. Advanced users can still set custom fees if needed.
Adds a button in the advanced settings that enables the app to start in testnet automatically on the next start. The setting is only valid for the next start, and it gets reset after that.
With the current setup, on smaller screens, buy & receive buttons have no proper padding. For action buttons, on smaller screens, the buttons have improper wordbreak causing them to look odd.
Revamp buy sell action buttons. Previously we use 2-step approach here. First user needs to select via radio button, then click on the action button (next). In this commit, we changed the radio buttons to become clickable card / normal buttons called ActionableItem. And when clicked, this will bring the user to the next screen. This eliminates the need for the next button and shortens the steps the user need to take. On screen width <=400px, we hide the exchange badges to save space and also set the back button to full width
- Similar to the USB HID descriptor product string - Empty `""` means the device has not set it yet - "no connection" is defined by the bluetooth firmware as not connected to either firmware/bootloader yet - The bluetooth firmware updates it dynamically, as the device can reboot into bootloader/firwmware without bluetooth disconnecting. The app listens on the change and connects/disconnects the right device accordingly. - For now we map to "BitBox02BTC" to get a connection going, later we will modify bitbox02-api-go to extend it with the official new product strings so the backend can identify them
Default to show the amount of the tx for all transactions, and then add the fee for non-erc20 ones.
ERC20 tokens are now exported with the correct value for "unit" Added a new column "FeeUnit" as the fee is displayed in ETH/wei for ERC20 tokens.
Text in message component can always be set to left align unless we introduce proper support for right-to-left langauges.
Including a check if the BitBox02 identified it as a send-to-self.
Rename 'Buy & Sell' title to 'Select account' for clarity in the account selector of Buy & Sell page. The same behaviour can be seen for the Receive account selector.
Currently, Windows users need to manually create a desktop shortcut. This PR creates a desktop shortcut during the installation process.
If no firmware is bundled, don't panic. This is currently the case if connecting a BitBox02 Plus, which does not yet have any firmware bundled in the app.
``` go get github.com/BitBoxSwiss/bitbox02-api-go@2b90fad go mod tidy go mod vendor ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )