Somewhat fix overlapping layer labels beyond layer 2#36
Open
zemm wants to merge 1 commit intokiibohd:masterfrom
Open
Somewhat fix overlapping layer labels beyond layer 2#36zemm wants to merge 1 commit intokiibohd:masterfrom
zemm wants to merge 1 commit intokiibohd:masterfrom
Conversation
Previously layers 1, 3, 5 and 7 were positioned to the top center, layers 2, 4 and 6 to the bottom center. These labels were unreadable in all cases, since they overlapped each other. This change places the labels like so: +-------+ | 3 1 5 | | 0 7 | | 4 2 6 | +-------+ The positions are chosen to maintain backwards compatibility with the old positioning with default layers 0-2. Of course there will still always be overlap with wider labels.
Member
|
Neat! @cubiq does this patch look good? I'm no good at evaluating css... |
|
that is something I tried, but it looked just too messy and opted for a 3-layers-at-a-time solution. I'll check if everything's working and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously layers 1, 3, 5 and 7 were positioned to the top
center, layers 2, 4 and 6 to the bottom center. These labels
were unreadable in all cases, since they overlapped each other.
This change places the labels like so:
The positions are chosen to maintain backwards compatibility
with the old positioning with default layers 0-2.
Of course there will still always be overlap with wider labels.