Skip to content

Somewhat fix overlapping layer labels beyond layer 2#36

Open
zemm wants to merge 1 commit intokiibohd:masterfrom
zemm:fix/overlapping-layers
Open

Somewhat fix overlapping layer labels beyond layer 2#36
zemm wants to merge 1 commit intokiibohd:masterfrom
zemm:fix/overlapping-layers

Conversation

@zemm
Copy link

@zemm zemm commented May 2, 2016

Previously layers 1, 3, 5 and 7 were positioned to the top
center, layers 2, 4 and 6 to the bottom center. These labels
were unreadable in all cases, since they overlapped each other.

This change places the labels like so:

+-------+
| 3 1 5 |
|   0 7 |
| 4 2 6 |
+-------+

The positions are chosen to maintain backwards compatibility
with the old positioning with default layers 0-2.

Of course there will still always be overlap with wider labels.

configurator-overlapping

Previously layers 1, 3, 5 and 7 were positioned to the top
center, layers 2, 4 and 6 to the bottom center. These labels
were unreadable in all cases, since they overlapped each other.

This change places the labels like so:

+-------+
| 3 1 5 |
|   0 7 |
| 4 2 6 |
+-------+

The positions are chosen to maintain backwards compatibility
with the old positioning with default layers 0-2.

Of course there will still always be overlap with wider labels.
@haata
Copy link
Member

haata commented May 3, 2016

Neat!

@cubiq does this patch look good? I'm no good at evaluating css...

@cubiq
Copy link

cubiq commented May 3, 2016

that is something I tried, but it looked just too messy and opted for a 3-layers-at-a-time solution.

I'll check if everything's working and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants