Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken support for Puma 6.5.0 v0.5.0 #30

Merged
merged 21 commits into from
Dec 4, 2024
Merged

Fix broken support for Puma 6.5.0 v0.5.0 #30

merged 21 commits into from
Dec 4, 2024

Conversation

kigster
Copy link
Owner

@kigster kigster commented Dec 2, 2024

Adding (*, **, &) arguments to #default_config_values method. Fixing CI specs run

* Adding the lock files
@kigster kigster mentioned this pull request Dec 4, 2024
@kigster kigster changed the title Puma 6.5.0 Support (WIP) Fix broken support for Puma 6.5.0 Dec 4, 2024
@kigster kigster added the work-in-progress This is being worked on label Dec 4, 2024
@kigster kigster self-assigned this Dec 4, 2024
@kigster kigster linked an issue Dec 4, 2024 that may be closed by this pull request
@kigster kigster added ready-for-merge and removed work-in-progress This is being worked on labels Dec 4, 2024
@kigster kigster changed the title Fix broken support for Puma 6.5.0 Fix broken support for Puma 6.5.0 v0.5.0 Dec 4, 2024
Upload codecov only when the ruby is the latest version from the matrix.
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.81%. Comparing base (6dc87c1) to head (b82725b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/puma/daemon/version.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files           7        7           
  Lines          77       77           
=======================================
  Hits           63       63           
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kigster kigster merged commit 790cdcc into master Dec 4, 2024
5 checks passed
@kigster kigster deleted the kig/puma-6.5.0 branch December 4, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puma v6.5.0 not started
1 participant