Wait for animations to complete after performing a scroll action#1170
Closed
justinseanmartin wants to merge 1 commit intokif-framework:masterfrom
Closed
Wait for animations to complete after performing a scroll action#1170justinseanmartin wants to merge 1 commit intokif-framework:masterfrom
justinseanmartin wants to merge 1 commit intokif-framework:masterfrom
Conversation
dostrander
approved these changes
Aug 27, 2020
Contributor
|
Is there a test we can add for this fix? |
harleyjcooper
approved these changes
Aug 28, 2020
Contributor
Author
|
Declined in favor of #1210, which has a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing an issue where we're unable to tap on an element right after performing a
-[KIFUIViewTestActor scrollByFractionOfSizeHorizontal:vertical:]action. It appears to help ensure that the view has stabilized before attempting to interact with that UI element.