-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Support Multiple YouTube API Keys #606
[Enhancement] Support Multiple YouTube API Keys #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking a swing at this! I've left a few small changes, but overall this is in good shape
I'm really impressed given this is your first go with Elixir! The language itself has some paradigms that are strange if you aren't familiar with them (like Agents)
edit: also, would you mind running mix check
before the next push? If that's giving you trouble then just let me know and I can run it 🤙
Thanks for your detailed explanations! I think I fixed everything you suggested. Here's the output of your requested mix check ouput
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you once again. I'll merge once CI passes
What's new?
Add support for multiple comma separated YouTube API keys.
What's changed?
N/A
What's fixed?
N/A
Any other comments?
I am pretty unfamiliar with Elixir, so forgive me if my code is atrocious.
This helps users who use the api with many sources and hit the daily limit.
Nothing changes for other users and there is effectively no downside.
Nothing changes in the database, we just parse the comma separated values when we need a key.
This uses a round-robin approach for cycling through the keys. I chose it because it evenly uses the keys and is pretty simple.
The other options I thought of were:
All tests pass for me
TODO