[MBL-2881] Add ServerDrivenUI module #2655
Open
+90
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevestreza-ksr
force-pushed
the
stevestreza/sdui-content/module
branch
from
2a4080f to
7c4b5e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Creates the ServerDrivenUI module, using Swift 6, and hooks it up to the Library-iOS module. Test target was also added to the Library-iOS testing phase.
As a note, because this imports GraphAPI, that means that GraphAPI needs to be included in a bunch more modules (along with the mocks bundle being included in tests).
👀 See
Spike
Epic
Verify
import ServerDrivenUIin Library-iOS somewhere, and logSDUI.name()to the console.ServerDrivenUITests.swiftfail