Skip to content

Commit

Permalink
MBL-1902: Fix circleCI builds (#2174)
Browse files Browse the repository at this point in the history
* FIX CIRCLE CI BUILD FORCING JVM 17

* force jvm 17 on fastlane

* update lanes to force jvm 17

* upgrade internal version name
  • Loading branch information
jlplks authored Nov 21, 2024
1 parent d3c7fea commit 952fef2
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ GEM

PLATFORMS
arm64-darwin-22
arm64-darwin-24

DEPENDENCIES
activesupport
Expand Down
2 changes: 1 addition & 1 deletion app/internal_version_code.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2014150920
2014150921
2 changes: 1 addition & 1 deletion app/internal_version_name.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.26.1
3.26.2
6 changes: 3 additions & 3 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ lane :alpha do
version_name = Milkrun::VersionName.new(audience: audience).read
slack_message = ["🚀",audience,build_type,"|",version_name,version_code,"successfully delivered to Firebase!"].join(' ')

build_android_app(task: "assembleInternalDebug")
build_android_app(task: "assembleInternalDebug -Dorg.gradle.java.home=/usr/lib/jvm/java-17-openjdk-amd64")

firebase_app_distribution(
app: Milkrun::FirebaseCredentialsExtractor.new.internal_debug,
Expand All @@ -35,7 +35,7 @@ lane :external do
slack_message = ["🚀",audience,build_type,"|",version_name,version_code,"successfully delivered to Firebase!"].join(' ')
release_notes = "Release " + version_name

build_android_app(task: "assembleExternalRelease")
build_android_app(task: "assembleExternalRelease -Dorg.gradle.java.home=/usr/lib/jvm/java-17-openjdk-amd64")

firebase_app_distribution(
app: Milkrun::FirebaseCredentialsExtractor.new.external_release,
Expand Down Expand Up @@ -63,7 +63,7 @@ lane :internal do
version_name = Milkrun::VersionName.new(audience: audience).read
slack_message = ["🚀",audience,build_type,"|",version_name,version_code,"successfully delivered to S3 and Firebase!"].join(' ')

build_android_app(task: "assembleInternalRelease")
build_android_app(task: "assembleInternalRelease -Dorg.gradle.java.home=/usr/lib/jvm/java-17-openjdk-amd64")

path_to_apk = lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH]
Milkrun::S3Package.new(version_code: version_code, file_path: path_to_apk).upload
Expand Down

0 comments on commit 952fef2

Please sign in to comment.