test: rollback 호출하는지 확인하도록 수정 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success23 tests passing in 8 suites. Report generated by 🧪jest coverage report action from 8b12c0b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경 사항
실제로 롤백되는 것을 확인하는 것이 아니라,
AbstractConnection#rollback을 호출하는지를 확인합니다.변경 이유
실제로 롤백되는지 확인하는 것까지 테스트하면,
@Transactional데코레이터를 테스트하는 것이 아니라mikro-orm의 동작을 테스트하는 것이 됩니다.이는 의도한 바가 아니기 때문에,
rollback메서드를 호출하는지만 확인하는 것으로 수정하였습니다.