Add falling block animation with <FallingBlock/>
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please format. |
kkysen
requested changes
Sep 3, 2022
src/util/playerUtil.tsx
Outdated
Comment on lines
140
to
146
| export function dropFloatingCells( | ||
| board: BoardCell[][], | ||
| ): [BoardCell[][], [number, number][], [number, number][]] { | ||
| ): [BoardCell[][], BoardCell[], BoardCell[]] { | ||
| // Returns an array of 3 arrays: | ||
| // Array 1: The resulting board with drops. | ||
| // Array 1: The resulting board with the only old coords removed. | ||
| // Array 2: The array for the coords of the floating cells, post-drop. | ||
| // Array 3: Array for the old coords of the floating cells. |
There was a problem hiding this comment.
I think this should just return an object with field names that describe their use instead of only putting that information in the documentation here.
There was a problem hiding this comment.
I was talking about the return type. It shouldn't be a tuple with comments describing what each index means, it should be an object with self-describing fields.
There was a problem hiding this comment.
I see what you mean. That's a great change. Updated it again
|
Lint and Format are still failing in CI, though. |
bytewife
force-pushed
the
falling_block
branch
from
250bfe7 to
809ae14
Compare
bytewife
force-pushed
the
falling_block
branch
from
809ae14 to
5a012d6
Compare
bytewife
force-pushed
the
falling_block
branch
from
3da0a69 to
73cd4cc
Compare
|
I had forgotten to include |
This is caused by Bun not being able to install `react-scripts`. Discussed in #44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Although slight non-deterministic behavior existed before this PR, it is more apparent now during the fall animations. This should be addressed in Remove non-determinism #51