Refactoring code #2

VladShyrokyi · 2021-06-02T20:41:16Z

Added classes:

core for build main game process
board for storing data
element - simple dto
updateLoop - for execute iterable logic

Added interface:

IElementGenerator for creating elements

# Conflicts: # C#/RandomElementGenerator.cs

Mini patch

… to main class Core<T>, move ulong core to another namespace

…dded the opportunity to set instantiator

[ADD] Move logic of interaction with values into an inherited class. [ADD] Move logic of iterabling of board elements when update into an inherited class.

…Generator.cs

…o local project solution references in example

…rties to ICellBehavior interface

Refactoring

# Conflicts: # C#/Board.cs # C#/BoardHelper.cs # C#/Core.cs # C#/Element.cs # C#/IElementGenerator.cs # C#/RandomCellGenerator.cs # C#/UpdateLoop.cs # ConsoleOut/ConsoleOut.csproj # ConsoleOut/Program.cs # Core_2048.csproj

Update assembly

[ADD] Update README.md

VladShyrokyi added 19 commits April 22, 2021 20:33

Init

e99f18a

refactoring - create static utils

0c941f4

code clean up

3b0e8bb

ignore

5968b5c

fixup! code clean up

9f4f9cf

refactoring - moved inner loop to self file

37078b2

added system file

a8c156f

Added readme

a9495fc

Added readme

7ce3e6c

Merge remote-tracking branch 'origin/master'

ed8ab27

Update lib, great refactoring

17f34ed

create random element generator builder

d0d52b4

create random element generator builder

9308a1d

Merge remote-tracking branch 'origin/master'

748bbcd

# Conflicts: # C#/RandomElementGenerator.cs

added RandomElementGenerator.cs ulong default class

4e09ecf

code clean up

b99e5d0

update README.md

28d4813

update png

c846b76

clean md

bb9c127

VladShyrokyi closed this Jun 4, 2021

VladShyrokyi reopened this Jun 4, 2021

VladShyrokyi marked this pull request as draft June 5, 2021 12:16

VladShyrokyi marked this pull request as ready for review June 5, 2021 12:16

VladShyrokyi marked this pull request as draft June 5, 2021 12:17

VladShyrokyi marked this pull request as ready for review June 5, 2021 12:20

VladShyrokyi and others added 5 commits June 5, 2021 16:34

change c# version Console app example to 7.3

aed8581

fix Board constructor

c4e9b61

remove redundant dependencies and clear code

f68105b

Merge pull request #1 from VladShyrokyi/fixs

6d8bc3f

Mini patch

Merge remote-tracking branch 'origin/master'

434dcda

VladShyrokyi and others added 29 commits July 4, 2021 16:30

Refactoring - remove redundant builder pattern, collapse all subclass…

b97cbfe

… to main class Core<T>, move ulong core to another namespace

refactoring - remove redundant builder from RandomElementGenerator, a…

8fe307f

…dded the opportunity to set instantiator

code clean up example

43b2e97

added null point exception when building UpdateLoop

ce17cfd

refactoring - rename delegate, change signature

ae460e1

[ADD] Comments to Board.cs, overloading operators ==/!=

b4b1ccb

[ADD] Comments to Element.cs

117265c

[REFACTORING] Remove redundant builders and delegate.

7c4bd27

[ADD] Move logic of interaction with values into an inherited class. [ADD] Move logic of iterabling of board elements when update into an inherited class.

[FIX] Range out exception when all Percentage less 1 in RandomElement…

e5109fb

…Generator.cs

[FIX] Removed redundant references, changed nuget package reference t…

a505d43

…o local project solution references in example

[REFACTORING] Remove classes extended for ulong

832b489

[REFACTORING] Rename main class

484618a

[REFACTORING] Remove Element builder

84db59b

[REFACTORING] Rename Element to Cell

bf29f15

[REFACTORING] Rename IElementGenerator to ICellGenerator

70f6854

[REFACTORING] Remove UpdateLoop builder

6005608

[REFACTORING] Remove BoardBehavior builder

28bb855

[REFACTORING] Change merge, predicate delegates, and base value prope…

8e47639

…rties to ICellBehavior interface

[FIX] Encapsulated fields in BoardBehavior

33d1aac

[FIX] Encapsulating UpdateLoop class - moved into BoardBehavior

20d04aa

[REFACTORING] Moved iterating logic into UpdateLoop

d6cc0e0

[REFACTORING] Remove builder on RandomCellGenerator

a0f8366

[UPDATED] File README.md

2dfb730

Merge pull request #2 from VladShyrokyi/refactoring

2cc40bb

Refactoring

Merge remote-tracking branch 'origin/master'

074fceb

# Conflicts: # C#/Board.cs # C#/BoardHelper.cs # C#/Core.cs # C#/Element.cs # C#/IElementGenerator.cs # C#/RandomCellGenerator.cs # C#/UpdateLoop.cs # ConsoleOut/ConsoleOut.csproj # ConsoleOut/Program.cs # Core_2048.csproj

[ADD] Update AssemblyInfo.cs

1e4246d

Merge pull request #3 from VladShyrokyi/update_assembly

c4530df

Update assembly

[ADD] Update README.md

9cb84fd

Merge pull request #4 from VladShyrokyi/update_assembly

c0a4e39

[ADD] Update README.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring code #2

Refactoring code #2

VladShyrokyi commented Jun 2, 2021

Refactoring code #2

Are you sure you want to change the base?

Refactoring code #2

Conversation

VladShyrokyi commented Jun 2, 2021