Fix the type of id on type BaseItem, to be type unknown, not string
#9054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7956a1b:
|
emmatown
reviewed
Mar 6, 2024
| @@ -442,7 +442,7 @@ export async function checkUniqueItemExists ( | |||
| throw missingItem(operation, uniqueInput) | |||
| } | |||
|
|
|||
| return { id: item.id.toString() } | |||
| return { id: item.id } | |||
There was a problem hiding this comment.
Removing this toString will break if you have a bigint since a bigint wouldn't be accepted by the ID type
emmatown
reviewed
Mar 6, 2024
| @@ -14,7 +14,7 @@ export type BaseListTypeInfo<Session = any> = { | |||
| create: GraphQLInput | |||
| update: GraphQLInput | |||
| where: GraphQLInput | |||
| uniqueWhere: { readonly id?: string | number | null } & GraphQLInput | |||
| uniqueWhere: { readonly id?: unknown } & GraphQLInput | |||
There was a problem hiding this comment.
string | number | null covers all that the input ID GraphQL type could be, what does widening this help?
emmatown
reviewed
Mar 6, 2024
| data: { listKey, itemId: item.id.toString() }, | ||
| data: { | ||
| listKey, | ||
| itemId: item.id |
There was a problem hiding this comment.
If you had a bigint id, this would fail since JSON.stringify with a bigint throws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the type of
idon typeBaseItemto be of typeunknowninstead ofstring. This helps reduce a number of type errors wherestring | number | nullis possible, but onlystringwas accepted by theBaseItem.This is not strictly related to #8846, but will likely be required as part of fixing that problem in any event.