Separate keymaps.h file (rebased)

[andrewgdotcom]

Same as previous PR #64, but rewritten on top of latest upstream/master.

[andrewgdotcom]

Any chance of getting an opinion one way or another on this PR? Keeping it open and mergeable while master constantly changes underneath it is time-consuming.

CF original discussion here: #28

[obra]

I'm really sorry for letting this drag out. On the one hand, it's not quite what I want for the regular Model 01 sketch. On the other hand, it's a really valuable thing for some folks. Would you be up for resubmitting it as a new PR against Kaleidoscope adding it as another Model 01 example sketch?

…

On Sat, Mar 7, 2020 at 6:51 AM Andrew Gallagher ***@***.***> wrote: Any chance of getting an opinion one way or another on this PR? Keeping it open and mergeable while master constantly changes underneath it is time-consuming. CF original discussion here: #28 <#28> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#84?email_source=notifications&email_token=AAALC2HONOUBMBI4GL4W42LRGJNOBA5CNFSM4HCCJEJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOD3KBY#issuecomment-596096263>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALC2ALRG7LSC4QKSWNAU3RGJNOBANCNFSM4HCCJEJA> .

[andrewgdotcom]

I can do that if you think it will be useful, but from my PoV its main usefulness lies in being able to maintain local modifications to this repo while tracking upstream. Large, single config files mean more merge conflicts.

If you think there is a better way of doing this, say by using a config.d directory, I'm all for it.

[obra]

This has been hanging out in my inbox as I've been continuing to ponder it. (Of course, in the meantime, the Model 01 firmware hasn't been seeing many changes ;) Being able to override keymaps inside a config directory is certainly a reasonable pattern and would work well with my desire to have the default firmware sketch as a single, relatively readable file It -is- my intent to migrate the default sketch into Kaleidoscope's repo as we work on reducing the number of places folks need to look to find things, but it hasn't exactly been urgent.

…

On Thu, Apr 16, 2020 at 7:22 AM Andrew Gallagher ***@***.***> wrote: I can do that if you think it will be useful, but from my PoV its main usefulness lies in being able to maintain local modifications to this repo while tracking upstream. Large, single config files mean more merge conflicts. If you think there is a better way of doing this, say by using a config.d directory, I'm all for it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALC2BFFHPVXBADW3B7C2DRM4IDRANCNFSM4HCCJEJA> .