Skip to content

deduplicate silent notifications #28899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zoom-ua wants to merge 2 commits into
base: master
Choose a base branch
from
Open

deduplicate silent notifications #28899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ed33d1
deduplicate silent notifications
zoom-ua Feb 13, 2026
284135b
lock
zoom-ua Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions go/bind/notifications.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@ import (
"fmt"
"regexp"
"runtime"
"strconv"
"sync"
"time"

lru "github.com/hashicorp/golang-lru"
"github.com/keybase/client/go/chat"
"github.com/keybase/client/go/chat/globals"
"github.com/keybase/client/go/chat/storage"
Expand All @@ -20,6 +23,21 @@ import (
"github.com/kyokomi/emoji"
)

const seenNotificationsCacheSize = 100

var (
seenNotificationsMtx sync.Mutex
seenNotifications *lru.Cache
seenNotificationsOnce sync.Once
)

func getSeenNotificationsCache() *lru.Cache {
seenNotificationsOnce.Do(func() {
seenNotifications, _ = lru.New(seenNotificationsCacheSize)
})
return seenNotifications
}

type Person struct {
KeybaseUsername string
KeybaseAvatar string
Expand Down Expand Up @@ -106,6 +124,20 @@ func HandleBackgroundNotification(strConvID, body, serverMessageBody, sender str
return libkb.LoginRequiredError{}
}
mp := chat.NewMobilePush(gc)
// Dedupe by convID||msgID
dupKey := strConvID + "||" + strconv.Itoa(intMessageID)
// Check if we've already processed this notification but without
// serializing the whole function. We check the map again while holding
// a lock before anything is displayed.
if _, ok := getSeenNotificationsCache().Get(dupKey); ok {
// Cancel any duplicate visible notifications
if len(pushID) > 0 {
mp.AckNotificationSuccess(ctx, []string{pushID})
}
kbCtx.Log.CDebugf(ctx, "HandleBackgroundNotification: duplicate notification convID=%s msgID=%d", strConvID, intMessageID)
// Return nil (not an error) so Android does not treat this as failure and show a fallback notification.
return nil
}
uid := gregor1.UID(kbCtx.Env.GetUID().ToBytes())
convID, err := chat1.MakeConvID(strConvID)
if err != nil {
Expand Down Expand Up @@ -195,7 +227,20 @@ func HandleBackgroundNotification(strConvID, body, serverMessageBody, sender str

// only display and ack this notification if we actually have something to display
if pusher != nil && (len(chatNotification.Message.Plaintext) > 0 || len(chatNotification.Message.ServerMessage) > 0) {
// Lock and check if we've already processed this notification.
seenNotificationsMtx.Lock()
defer seenNotificationsMtx.Unlock()
if _, ok := getSeenNotificationsCache().Get(dupKey); ok {
// Cancel any duplicate visible notifications
if len(pushID) > 0 {
mp.AckNotificationSuccess(ctx, []string{pushID})
}
kbCtx.Log.CDebugf(ctx, "HandleBackgroundNotification: duplicate notification convID=%s msgID=%d", strConvID, intMessageID)
// Return nil (not an error) so Android does not treat this as failure and show a fallback notification.
return nil
}
pusher.DisplayChatNotification(&chatNotification)
getSeenNotificationsCache().Add(dupKey, struct{}{})
if len(pushID) > 0 {
mp.AckNotificationSuccess(ctx, []string{pushID})
}
Expand Down