Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download dependency and require Node.js 10 #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tjbulick
Copy link

Update dependency package called download in order to pull in security patch. This also increases required node.js version to 10

@tjbulick
Copy link
Author

Resolves #76

@apfelbox
Copy link

The CI failures seem unrelated to this PR

Copy link

@jimmyandrade jimmyandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danychi
Copy link

danychi commented Jan 7, 2021

Could you check this MR @kevva? 😊

@tjbulick
Copy link
Author

tjbulick commented Jan 7, 2021

By the way, i also checked that CI errors don't relate to my changes. But maybe repository maintainer would say that we need to fix them.

Anyway, i'm still here and ready to fix them, but it would be nice to hear something from the maintainer. Maybe he will just merge these changes despite CI errors, at least because in past versions he already did so.

@@ -1,5 +1,4 @@
language: node_js
node_js:
- '12'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add 14

@XhmikosR
Copy link
Contributor

XhmikosR commented Feb 23, 2021

BTW it'd be nice to switch to GitHub Actions. Also, check if pify is really needed and if we could just use util.promisify

@XhmikosR XhmikosR mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants