New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add guard to `Size` #365

Merged

friendlymatthew merged 1 commit into main from guard-vectordim

Jul 1, 2024

Collaborator

friendlymatthew commented Jul 1, 2024

A common trap when creating a BTree is to zero out VectorDim. However, a VectorDim of 0 proceeds to screw up the Size calculation.


          add guard

ce3cd70

Collaborator Author

friendlymatthew commented Jul 1, 2024

Note: Instead, it'll panic.

friendlymatthew enabled auto-merge (squash)

July 1, 2024 16:53

friendlymatthew merged commit 3865e79 into main

9 checks passed

github-actions bot commented Jul 1, 2024

Benchmark results: https://github.com/kevmo314/appendable/actions/runs/9748097403/artifacts/1656364791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet