Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new slice objects in python3.14a1 and other small fixes #43

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Add support for new slice objects in python3.14a1 and other small fixes #43

merged 6 commits into from
Oct 18, 2024

Commits on Oct 18, 2024

  1. pyc: adjust magic range for python3.14a1

    @keszybz
    keszybz committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    49782ce View commit details
    Browse the repository at this point in the history

  2. pyc: adjust TODOs 

    The "content hash" is for the _source_ file, so it doesn't change if we
rewrite the pyc file. The TODO entry was completely bogus.

But as a follow-up, it'd be nice if we could notice the cases where we're
working on a file that doesn't actually work for the size and/or mtime of the
pyc file. This could help to diagnose the cases where the py file mtime was
changed after the pyc file was written.
    @keszybz
    keszybz committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b731a58 View commit details
    Browse the repository at this point in the history

  3. pyc: improve error message for unknown objects 

    This codepath didn't get exercised before, so the error message was
not very readable. It's much easier if we know that it's ':' that is not
implemented.
    @keszybz
    keszybz committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    52c5938 View commit details
    Browse the repository at this point in the history

  4. pyc: replace Rc::new by .into() calls

    @keszybz
    keszybz committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b440815 View commit details
    Browse the repository at this point in the history

  5. pyc: add support for slice objects 

    Added in c6127af8685c2a9b416207e46089cee79d028b85 for Python 3.14.

Closes #42.
    @keszybz
    keszybz committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b59c4fc View commit details
    Browse the repository at this point in the history

  6. tests: add test pyc files for python3.14 

    The files are taken from python3.14-3.14.0~a1-1.fc42.x86_64 scratch build and
.pyc.fixed were generated with freshly built add-det. As previously, those are
under license Python-2.0.1.

Add just a handful of files, incl. a few with the new slice serialization.
We end up rewriting the pyc files as serialization changes, increasing the
size of the repo. We don't really gain much from having a full hundred of
files writte by the same Python version.
    @keszybz
    keszybz committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    88b6692 View commit details
    Browse the repository at this point in the history