Fix writing of pyc header, add more tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I managed to somehow get this completely wrong. That number is the size of the original .py file, nothing related to the bytecode file itself. Unfortunately this causes python to ignore the pyc file (if the py file is there to compare), so it's a noticable bug. The packages that were built with that will need to be rebuilt. Unfortunately the test files that were adjusted previously need to be adjusted again.
A test was added earlier, but it didn't actually test how the result looks. Let's test this a bit more. We have 7 files matching tests/cases/python_stdlib/*/z*.fixed, this should be enough.
|
I rebuilt a package with those patches and the issue seems to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.