Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/string-formulas-excel-to-ion #77

Merged
merged 1 commit into from
Jan 4, 2024
Merged

fix/string-formulas-excel-to-ion #77

merged 1 commit into from
Jan 4, 2024

Conversation

brian-mulier-p
Copy link
Member

@brian-mulier-p brian-mulier-p commented Jan 4, 2024 •
edited
Loading

I added an 'UPPER' formula to the test sample to replicate the issue
image

@brian-mulier-p brian-mulier-p self-assigned this Jan 4, 2024
@brian-mulier-p brian-mulier-p force-pushed the fix/string-formulas-excel-to-ion branch from 0bb1403 to 8d3546b Compare January 4, 2024 14:44
@brian-mulier-p brian-mulier-p force-pushed the fix/string-formulas-excel-to-ion branch from 8d3546b to 3a56b77 Compare January 4, 2024 14:49
loicmathieu
loicmathieu approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-mulier-p brian-mulier-p merged commit 0ca244c into master Jan 4, 2024
1 check passed
@tchiotludo tchiotludo deleted the fix/string-formulas-excel-to-ion branch January 4, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brian-mulier-p @loicmathieu