fix: remove the inputstream.ready() check on the XmlReader

This check fails in GCS even for all input streams.
kestra-io · Dec 19, 2023 · c898a09 · c898a09
1 parent 4d457bd
commit c898a09
Showing 1 changed file with 22 additions and 24 deletions.
diff --git a/src/main/java/io/kestra/plugin/serdes/xml/XmlReader.java b/src/main/java/io/kestra/plugin/serdes/xml/XmlReader.java
@@ -74,31 +74,29 @@ public Output run(RunContext runContext) throws Exception {
             BufferedReader input = new BufferedReader(new InputStreamReader(runContext.uriToInputStream(from), charset));
             OutputStream output = new FileOutputStream(tempFile);
         ) {
-            if(input.ready()) {
-                XMLParserConfiguration xmlParserConfiguration = new XMLParserConfiguration();
-                if (parserConfiguration != null) {
-                    xmlParserConfiguration = xmlParserConfiguration.withForceList(parserConfiguration.getForceList());
-                }
-                JSONObject jsonObject = XML.toJSONObject(input, xmlParserConfiguration);
-
-                Object result = result(jsonObject);
-
-                if (result instanceof JSONObject) {
-                    Map<String, Object> map = ((JSONObject) result).toMap();
-                    FileSerde.write(output, map);
-                    runContext.metric(Counter.of("records", map.size()));
-                } else if (result instanceof JSONArray) {
-                    List<Object> list = ((JSONArray) result).toList();
-                    list.forEach(throwConsumer(o -> {
-                        FileSerde.write(output, o);
-                    }));
-                    runContext.metric(Counter.of("records", list.size()));
-                } else {
-                    FileSerde.write(output, result);
-                }
-
-                output.flush();
+            XMLParserConfiguration xmlParserConfiguration = new XMLParserConfiguration();
+            if (parserConfiguration != null) {
+                xmlParserConfiguration = xmlParserConfiguration.withForceList(parserConfiguration.getForceList());
             }
+            JSONObject jsonObject = XML.toJSONObject(input, xmlParserConfiguration);
+
+            Object result = result(jsonObject);
+
+            if (result instanceof JSONObject) {
+                Map<String, Object> map = ((JSONObject) result).toMap();
+                FileSerde.write(output, map);
+                runContext.metric(Counter.of("records", map.size()));
+            } else if (result instanceof JSONArray) {
+                List<Object> list = ((JSONArray) result).toList();
+                list.forEach(throwConsumer(o -> {
+                    FileSerde.write(output, o);
+                }));
+                runContext.metric(Counter.of("records", list.size()));
+            } else {
+                FileSerde.write(output, result);
+            }
+
+            output.flush();
         }
 
         return Output