Skip to content

fix(tests): attempt for flaky tests #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Malaydewangan09 merged 1 commit into from
Sep 4, 2025
Merged

fix(tests): attempt for flaky tests #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin-script-go/src/test/java/io/kestra/plugins/scripts/go/CommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ void should_create_output_csv() throws Exception {
var goScript = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/go_script.go"),
new URI("/file/storage/csv_output/go_script.go"),
IOUtils.toInputStream("""
package main
import (
Expand Down
2 changes: 1 addition & 1 deletion plugin-script-julia/src/test/java/io/kestra/plugin/scripts/julia/CommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ void task() throws Exception {
URI put = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new URI("/file/storage/tests/scripts/julia/get.yml"),
IOUtils.toInputStream(
"@info \"hello there!\";",
StandardCharsets.UTF_8
Expand Down
2 changes: 1 addition & 1 deletion plugin-script-node/src/test/java/io/kestra/plugin/scripts/node/CommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ void task() throws Exception {
URI put = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new URI("/file/storage/tests/scripts/node/get.yml"),
IOUtils.toInputStream(
"console.log('hello there!');",
StandardCharsets.UTF_8
Expand Down
2 changes: 1 addition & 1 deletion plugin-script-php/src/test/java/io/kestra/plugin/scripts/php/CommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void task() throws Exception {
var phpScript = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new URI("/file/storage/tests/scripts/php/get.yml"),
IOUtils.toInputStream(
"""
#!/usr/bin/php
Expand Down
2 changes: 1 addition & 1 deletion plugin-script-powershell/src/test/java/io/kestra/plugin/scripts/powershell/CommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ void task() throws Exception {
URI put = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new URI("/file/storage/tests/scripts/powershell/get.yml"),
IOUtils.toInputStream(
"Get-ChildItem | Format-List",
StandardCharsets.UTF_8
Expand Down
2 changes: 1 addition & 1 deletion plugin-script-python/src/test/java/io/kestra/plugin/scripts/python/CommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void task() throws Exception {
URI put = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new URI("/file/storage/tests/scripts/python/get.yml"),
IOUtils.toInputStream(
"print('hello there!')",
StandardCharsets.UTF_8
Expand Down
2 changes: 1 addition & 1 deletion plugin-script-python/src/test/java/io/kestra/plugin/scripts/python/ScriptTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ void inputs(RunnerType runner, DockerOptions dockerOptions) throws Exception {
URI put = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new URI("/file/storage/tests/scripts/get.yml"),
IOUtils.toInputStream(
"hello there!",
StandardCharsets.UTF_8
Expand Down
2 changes: 1 addition & 1 deletion plugin-script-r/src/test/java/io/kestra/plugin/scripts/r/CommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ void task() throws Exception {
URI put = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new URI("/file/storage/tests/scripts/r/get.yml"),
IOUtils.toInputStream(
"aString = \"Hello World!\"\n" +
"print (aString)",
Expand Down
2 changes: 1 addition & 1 deletion plugin-script-ruby/src/test/java/io/kestra/plugin/scripts/ruby/CommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ void task() throws Exception {
URI put = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new URI("/file/storage/tests/scripts/ruby/get.yml"),
IOUtils.toInputStream(
"puts \"Hello World!\"\n" +
"STDERR.puts \"done\"",
Expand Down
38 changes: 14 additions & 24 deletions plugin-script-shell/src/test/java/io/kestra/core/tasks/scripts/AbstractBashTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,7 @@ void useInputFiles() throws Exception {
void useInputFilesFromKestraFs() throws Exception {
URL resource = AbstractBashTest.class.getClassLoader().getResource("application.yml");

URI put = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new FileInputStream(Objects.requireNonNull(resource).getFile())
);
URI put = putUnique(storageInterface, resource);

Map<String, String> files = new HashMap<>();
files.put("test.sh", "cat fscontent.txt");
Expand Down Expand Up @@ -204,19 +199,9 @@ void useInputFilesFromKestraFs() throws Exception {
void useInputFilesAsVariable() throws Exception {
URL resource = AbstractBashTest.class.getClassLoader().getResource("application.yml");

URI put1 = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new FileInputStream(Objects.requireNonNull(resource).getFile())
);
URI put1 = putUnique(storageInterface, resource);

URI put2 = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new FileInputStream(Objects.requireNonNull(resource).getFile())
);
URI put2 = putUnique(storageInterface, resource);

Map<String, String> files = new HashMap<>();
files.put("1.yml", put1.toString());
Expand Down Expand Up @@ -246,12 +231,7 @@ void useInputFilesAsVariable() throws Exception {
void preventRelativeFile() throws Exception {
URL resource = AbstractBashTest.class.getClassLoader().getResource("application.yml");

URI put = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new FileInputStream(Objects.requireNonNull(resource).getFile())
);
URI put = putUnique(storageInterface, resource);

assertThrows(IllegalArgumentException.class, () -> {
Bash bash = configure(Bash.builder()
Expand Down Expand Up @@ -331,4 +311,14 @@ static <T> AbstractMetricEntry<T> getMetrics(RunContext runContext, String name)
.findFirst()
.orElseThrow();
}

private static URI putUnique(StorageInterface storage, URL resource) throws Exception {
String name = "test-" + UUID.randomUUID() + ".yml";
return storage.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/tests/" + name),
new FileInputStream(Objects.requireNonNull(resource).getFile())
);
}
}
2 changes: 1 addition & 1 deletion plugin-script-shell/src/test/java/io/kestra/plugin/scripts/shell/CommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ void files(RunnerType runner, DockerOptions dockerOptions) throws Exception {
URI put = storageInterface.put(
TenantService.MAIN_TENANT,
null,
new URI("/file/storage/get.yml"),
new URI("/file/storage/tests/scripts/shell/get.yml"),
IOUtils.toInputStream("I'm here", StandardCharsets.UTF_8)
);

Expand Down
2 changes: 1 addition & 1 deletion plugin-script/src/main/java/io/kestra/core/tasks/scripts/AbstractBash.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ protected io.kestra.core.tasks.scripts.ScriptOutput run(RunContext runContext, S
if (!rFiles.isEmpty()) {
allOutputs.addAll(rFiles);
}

Map<String, String> outputFilePaths = PluginUtilsService.createOutputFiles(
workingDirectory,
allOutputs,
Expand Down
Loading