-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/samba #87
feat/samba #87
Conversation
3f34eb1
to
8c06fc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you add all those libraries inside the Gradle config and why it's not possible to use the standard common-vfs library?
Doing so will add maintenance cost as we would need to follow the changes upstream and do a release each time it's released upstream.
I added some comments but I have no strong opinion on the commons-vfs2 fork, that was already on the branch from @tchiotludo but I think it was mostly for sandbox but as I no longer use that dependency maybe we should go back on that release 🤔. |
If sandbox is not needed, please use the official release |
8c06fc5
to
1a5161c
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #23